Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1228713003: Move protocol registration from WebViewClient to WebFrameClient, part 1/3. (Closed)

Created:
5 years, 5 months ago by Avi (use Gerrit)
Modified:
5 years, 5 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move protocol registration from WebViewClient to WebFrameClient, part 1/3. BUG=304341 TEST=protocol registration still works Committed: https://crrev.com/a23e16b2487eb27949a3e0c9eaf2c20385c7346a Cr-Commit-Position: refs/heads/master@{#338036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +13 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Avi (use Gerrit)
Nasko, here's part 1; it's boring. Part 2 is the fun in Blink. https://codereview.chromium.org/1226113002/ , ...
5 years, 5 months ago (2015-07-08 21:41:21 UTC) #2
nasko
LGTM
5 years, 5 months ago (2015-07-09 12:31:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228713003/1
5 years, 5 months ago (2015-07-09 12:31:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 13:23:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228713003/1
5 years, 5 months ago (2015-07-09 14:14:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 14:19:02 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 14:20:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a23e16b2487eb27949a3e0c9eaf2c20385c7346a
Cr-Commit-Position: refs/heads/master@{#338036}

Powered by Google App Engine
This is Rietveld 408576698