Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1230213002: Use entry rather than index in ElementsAccessor::Get (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use entry rather than index in ElementsAccessor::Get BUG=v8:4137, v8:4177 LOG=n Committed: https://crrev.com/7b5eab583f93980a449e901597e10a81c756526f Cr-Commit-Position: refs/heads/master@{#29574}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -72 lines) Patch
M src/elements.h View 1 1 chunk +2 lines, -11 lines 0 comments Download
M src/elements.cc View 1 9 chunks +44 lines, -60 lines 0 comments Download
M src/lookup.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-10 12:18:56 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-10 13:21:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230213002/20001
5 years, 5 months ago (2015-07-10 13:24:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 14:13:34 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 14:13:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b5eab583f93980a449e901597e10a81c756526f
Cr-Commit-Position: refs/heads/master@{#29574}

Powered by Google App Engine
This is Rietveld 408576698