Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/elements.h

Issue 1230213002: Use entry rather than index in ElementsAccessor::Get (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 584f1b54d714774238778777b8724bf8344982e2..511b636c3de8082ed2c5dfe16251e7d5e8da08c1 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -38,17 +38,8 @@ class ElementsAccessor {
return HasElement(holder, index, handle(holder->elements()));
}
- // Returns the element with the specified index or undefined if there is no
- // such element. This method doesn't iterate up the prototype chain. The
- // caller can optionally pass in the backing store to use for the check, which
- // must be compatible with the ElementsKind of the ElementsAccessor. If
- // backing_store is NULL, the holder->elements() is used as the backing store.
- virtual Handle<Object> Get(Handle<JSObject> holder, uint32_t index,
- Handle<FixedArrayBase> backing_store) = 0;
-
- inline Handle<Object> Get(Handle<JSObject> holder, uint32_t index) {
- return Get(holder, index, handle(holder->elements()));
- }
+ virtual Handle<Object> Get(Handle<FixedArrayBase> backing_store,
+ uint32_t entry) = 0;
// Modifies the length data property as specified for JSArrays and resizes the
// underlying backing store accordingly. The method honors the semantics of
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698