Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5603)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 12302034: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adding Tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
index e16ac31ba6708b831db9ae77f0e8adfbba06cf39..29df5d5a88ab0d22549aeb0b35cdc08b893bf39c 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
@@ -47,8 +47,8 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
const std::vector<int>& identifiers);
// Hides the popup and destroys the controller. This also invalidates
- // |delegate_|. Virtual for testing.
- virtual void Hide();
+ // |delegate_|.
+ virtual void Hide() OVERRIDE;
Ilya Sherman 2013/02/22 00:29:04 nit: Move this to be grouped with the other "Autof
csharp 2013/02/22 15:41:31 This needs to be public though, the other function
Ilya Sherman 2013/02/23 00:02:36 Ah, awkward. Dunno if Evan has a preference on ho
// KeyboardListener implementation.
virtual bool HandleKeyPressEvent(

Powered by Google App Engine
This is Rietveld 408576698