Always Close the Autofill UI through the same path

chrome/browser/ui/autofill/autofill_popup_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
@@ skipping 29 matching lines @@
       gfx::NativeView container_view,
       const gfx::RectF& element_bounds);
 
   // Shows the popup, or updates the existing popup with the given values.
   void Show(const std::vector<string16>& names,
             const std::vector<string16>& subtexts,
             const std::vector<string16>& icons,
             const std::vector<int>& identifiers);
 
   // Hides the popup and destroys the controller. This also invalidates
-  // |delegate_|. Virtual for testing.
-  virtual void Hide();
+  // |delegate_|.
+  virtual void Hide() OVERRIDE;

[Ilya Sherman, 2013/02/22 00:29:04]

nit: Move this to be grouped with the other "AutofillPopupController
implementation." overrides.

[csharp, 2013/02/22 15:41:31]

This needs to be public though, the other functions are protected.

[Ilya Sherman, 2013/02/23 00:02:36]

Ah, awkward.  Dunno if Evan has a preference on how to treat methods that are
meant to be callable both by the controller's delegate and by the view.

 
   // KeyboardListener implementation.
   virtual bool HandleKeyPressEvent(
       const content::NativeWebKeyboardEvent& event) OVERRIDE;
 
  protected:
   FRIEND_TEST_ALL_PREFIXES(AutofillExternalDelegateBrowserTest,
                            CloseWidgetAndNoLeaking);
 
   AutofillPopupControllerImpl(AutofillPopupDelegate* delegate,
@@ skipping 141 matching lines @@
   // Used to indicate if the delete icon within a row is currently selected.
   bool delete_icon_hovered_;
 
   // True if |HideInternal| has already been called.
   bool is_hiding_;
 
   base::WeakPtrFactory<AutofillPopupControllerImpl> weak_ptr_factory_;
 };
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_