Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1230203005: Revert "appendHtml, when sanitizing, should create document fragment in the right context" (Closed)

Created:
5 years, 5 months ago by Alan Knight
Modified:
5 years, 5 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "appendHtml, when sanitizing, should create document fragment in the right context" This reverts commit 930a40daa50a93adfce8786f4d7ef25e06324dda. BUG= Committed: https://github.com/dart-lang/sdk/commit/610edadff23220904c6a712a4491fe444fe92451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -85 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +2 lines, -18 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +4 lines, -20 lines 0 comments Download
M tests/html/element_add_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alan Knight
TBR Also re-ran go.sh, which should fully revert the dartium/JS interop changes.
5 years, 5 months ago (2015-07-13 22:31:31 UTC) #2
Alan Knight
5 years, 5 months ago (2015-07-13 22:32:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
610edadff23220904c6a712a4491fe444fe92451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698