Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2182)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 1230203005: Revert "appendHtml, when sanitizing, should create document fragment in the right context" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/element_add_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 14c2a078f5cba41a7b451018ea624917dbbc628c..8eb08da6c67246d4c000738e3e85013a43403dce 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -13670,7 +13670,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
if (treeSanitizer is _TrustedHtmlTreeSanitizer) {
_insertAdjacentHtml(where, html);
} else {
- _insertAdjacentNode(where, createFragment(html,
+ _insertAdjacentNode(where, new DocumentFragment.html(html,
validator: validator, treeSanitizer: treeSanitizer));
}
}
@@ -13880,9 +13880,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
_parseDocument.head.append(base);
}
var contextElement;
- // Head and Area elements can't be used to create document fragments.
- // Use the body instead.
- if (this is BodyElement || _cannotBeUsedToCreateContextualFragment) {
+ if (this is BodyElement) {
contextElement = _parseDocument.body;
} else {
contextElement = _parseDocument.createElement(tagName);
@@ -13911,20 +13909,6 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
return fragment;
}
- /** Test if createContextualFragment is supported for this element types */
- bool get _cannotBeUsedToCreateContextualFragment =>
- _tagsForWhichCreateContextualFragmentIsNotSupported.contains(tagName);
-
- /**
- * A hard-coded list of the tag names for which createContextualFragment
- * isn't supported.
- */
- static const _tagsForWhichCreateContextualFragmentIsNotSupported =
- const ['HEAD', 'AREA',
- 'BASE', 'BASEFONT', 'BR', 'COL', 'COLGROUP', 'EMBED', 'FRAME', 'FRAMESET',
- 'HR', 'IMAGE', 'IMG', 'INPUT', 'ISINDEX', 'LINK', 'META', 'PARAM',
- 'SOURCE', 'STYLE', 'TITLE', 'WBR'];
-
/**
* Parses the HTML fragment and sets it as the contents of this element.
*
@@ -36166,10 +36150,10 @@ class Url extends NativeFieldWrapperClass2 implements UrlUtils {
if ((blob_OR_source_OR_stream is Blob || blob_OR_source_OR_stream == null)) {
return _blink.BlinkURL.instance.createObjectURL_Callback_1_(unwrap_jso(blob_OR_source_OR_stream));
}
- if ((blob_OR_source_OR_stream is MediaStream)) {
+ if ((blob_OR_source_OR_stream is MediaSource)) {
return _blink.BlinkURL.instance.createObjectURL_Callback_1_(unwrap_jso(blob_OR_source_OR_stream));
}
- if ((blob_OR_source_OR_stream is MediaSource)) {
+ if ((blob_OR_source_OR_stream is MediaStream)) {
return _blink.BlinkURL.instance.createObjectURL_Callback_1_(unwrap_jso(blob_OR_source_OR_stream));
}
throw new ArgumentError("Incorrect number or type of arguments");
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/element_add_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698