Issue 1230073002: Teach SkyShell.apk to stop posting frames when not visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230073002: Teach SkyShell.apk to stop posting frames when not visible (Closed)

Created:
5 years, 5 months ago by eseidel

Modified:
5 years, 5 months ago

Reviewers:
abarth, abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach SkyShell.apk to stop posting frames when not visible This listens to both surface destruction as well as activity pause/unpause. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/964c6eed94e6ff9865723312d32dabbfd8156723

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -25 lines)			Patch
M	sky/services/engine/sky_engine.mojom	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java	View	2 chunks	+4 lines, -18 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyActivity.java	View	5 chunks	+25 lines, -5 lines	1 comment	Download
M	sky/shell/ui/animator.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	sky/shell/ui/animator.cc	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1230073002/diff/1/sky/shell/android/org/domokit/sky/shell/SkyActivity.java File sky/shell/android/org/domokit/sky/shell/SkyActivity.java (right): https://codereview.chromium.org/1230073002/diff/1/sky/shell/android/org/domokit/sky/shell/SkyActivity.java#newcode73 sky/shell/android/org/domokit/sky/shell/SkyActivity.java:73: // back behavior. We can delete this comment ...

5 years, 5 months ago (2015-07-09 23:45:23 UTC) #2

eseidel

5 years, 5 months ago (2015-07-10 17:26:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
964c6eed94e6ff9865723312d32dabbfd8156723 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages