Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5314)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1230063009: Disable DevToolsPixelOutputTests, TestScreenshotRecording under MSan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index da3227621c3823df6e39dadf8b60ec920f4768f3..7d7c5574594546d83b3c0d3aeffd4bc79c86daf6 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -987,8 +987,15 @@ class DevToolsPixelOutputTests : public DevToolsSanityTest {
}
};
+// This test enables switches::kUseGpuInTests which causes false positives
+// with MemorySanitizer.
+#if defined(MEMORY_SANITIZER)
+#define MAYBE_TestScreenshotRecording DISABLED_TestScreenshotRecording
+#else
+#define MAYBE_TestScreenshotRecording TestScreenshotRecording
+#endif
// Tests raw headers text.
-IN_PROC_BROWSER_TEST_F(DevToolsPixelOutputTests, TestScreenshotRecording) {
+IN_PROC_BROWSER_TEST_F(DevToolsPixelOutputTests,
+ MAYBE_TestScreenshotRecording) {
RunTest("testScreenshotRecording", std::string());
}
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698