Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1230063009: Disable DevToolsPixelOutputTests, TestScreenshotRecording under MSan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/cancelable_callback.h" 6 #include "base/cancelable_callback.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 969 matching lines...) Expand 10 before | Expand all | Expand 10 after
980 } 980 }
981 981
982 class DevToolsPixelOutputTests : public DevToolsSanityTest { 982 class DevToolsPixelOutputTests : public DevToolsSanityTest {
983 public: 983 public:
984 void SetUpCommandLine(base::CommandLine* command_line) override { 984 void SetUpCommandLine(base::CommandLine* command_line) override {
985 command_line->AppendSwitch(switches::kEnablePixelOutputInTests); 985 command_line->AppendSwitch(switches::kEnablePixelOutputInTests);
986 command_line->AppendSwitch(switches::kUseGpuInTests); 986 command_line->AppendSwitch(switches::kUseGpuInTests);
987 } 987 }
988 }; 988 };
989 989
990 // This test enables switches::kUseGpuInTests which causes false positives
991 // with MemorySanitizer.
992 #if defined(MEMORY_SANITIZER)
993 #define MAYBE_TestScreenshotRecording DISABLED_TestScreenshotRecording
994 #else
995 #define MAYBE_TestScreenshotRecording TestScreenshotRecording
996 #endif
990 // Tests raw headers text. 997 // Tests raw headers text.
991 IN_PROC_BROWSER_TEST_F(DevToolsPixelOutputTests, TestScreenshotRecording) { 998 IN_PROC_BROWSER_TEST_F(DevToolsPixelOutputTests,
999 MAYBE_TestScreenshotRecording) {
992 RunTest("testScreenshotRecording", std::string()); 1000 RunTest("testScreenshotRecording", std::string());
993 } 1001 }
994
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698