Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230013003: Remove the (already disabled) OverflowChangedEvent runtime flag (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, arv+blink, szager+layoutwatch_chromium.org, vivekg, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, vivekg_samsung, Inactive, jchaffraix+rendering, zoltan1, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove the (already disabled) OverflowChangedEvent runtime flag The functionality was disabled for M43: https://codereview.chromium.org/959643002 M43 reached the stable channel for Windows, Mac and Linux on May 19 and for Android on May 27, and there have been no issues reported. BUG=460822 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -323 lines) Patch
M Source/core/core.gypi View 5 chunks +0 lines, -7 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/events/OverflowEvent.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/events/OverflowEvent.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
D Source/core/events/OverflowEvent.idl View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/core/events/OverflowEventInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/frame/FrameView.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +0 lines, -32 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 3 chunks +0 lines, -45 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebDOMEvent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M public/web/WebDOMEvent.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230013003/1
5 years, 5 months ago (2015-07-10 12:33:15 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 13:56:11 UTC) #4
philipj_slow
PTAL? Has something to do with events, at least :)
5 years, 5 months ago (2015-07-10 13:59:29 UTC) #6
Rick Byers
Sure, LGTM - thanks for the cleanup!
5 years, 5 months ago (2015-07-10 14:07:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230013003/1
5 years, 5 months ago (2015-07-10 14:11:22 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 14:14:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198689

Powered by Google App Engine
This is Rietveld 408576698