Issue 12300043: Move setValue operation into a separate JsDeclarativeVariable interface

Issue 12300043: Move setValue operation into a separate JsDeclarativeVariable interface (Closed)

Created:
7 years, 10 months ago by Peter Rybin

Modified:
7 years, 10 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Move setValue operation into a separate JsDeclarativeVariable interface – Introduce JsDeclarativeVariable type, move setValue and isMutable methods there; – stop pretending SDK can implement setValue for object variables; – completely drop isReadable. Committed: https://code.google.com/p/chromedevtools/source/detail?r=1141

Patch Set 1 #

Patch Set 2 : clean #

Total comments: 8

Patch Set 3 : patch protocol 1.0 backend #

Patch Set 4 : fcr #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+375 lines, -355 lines)			Patch
M	plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java	View	1 2 3	5 chunks	+73 lines, -33 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1	6 chunks	+10 lines, -7 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java	View	1 2 3	8 chunks	+56 lines, -49 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueLoader.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1 2	6 chunks	+11 lines, -12 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipValueBuilder.java	View	1 2	6 chunks	+39 lines, -12 lines	0 comments	Download
A	plugins/org.chromium.sdk/src/org/chromium/sdk/JsDeclarativeVariable.java	View	1 2 3	1 chunk	+46 lines, -0 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/JsScope.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/JsVariable.java	View	1	2 chunks	+7 lines, -45 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java	View		4 chunks	+6 lines, -55 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java	View		5 chunks	+12 lines, -72 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableBase.java	View	1	6 chunks	+112 lines, -67 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apavlov

LGTM with comments https://codereview.chromium.org/12300043/diff/2001/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java File plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java (right): https://codereview.chromium.org/12300043/diff/2001/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java#newcode54 plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java:54: // to parallel if for several ...

7 years, 10 months ago (2013-02-20 09:02:02 UTC) #2

Peter Rybin

https://codereview.chromium.org/12300043/diff/2001/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java File plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java (right): https://codereview.chromium.org/12300043/diff/2001/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java#newcode54 plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java:54: // to parallel if for several properties. On 2013/02/20 ...

7 years, 10 months ago (2013-02-21 19:08:48 UTC) #3

Message was sent while issue was closed.

Committed manually as r1141 (presubmit successful).

Expand Messages | Collapse Messages