Fix spurious profile shortcuts created with a system-level install.

Fix spurious profile shortcuts created with a system-level install.

This issue was caused by RenameChromeDesktopShortcutForProfile()
having logic to copy a system-level shortcut to make a user-level
shortcut in the case where a non-profile Chrome shortcut would
need to become a profile shortcut (i.e. the first user's profile
shortcut when creating a second user).

This path was being triggered by the initial change of the profile
avatar when the profile was created. The fix is to not to try
updating profile shortcuts on name/avatar changes when we know the
profile never had a shortcut created (by virtue of the shortcut
name never getting stored).

BUG=177047
TEST=On a system-level install, create a new profile with the "create
shortcut" checkbox unchecked. A shortcut should not be created. Change
the profile's name or icon. The shortcut should still not appear.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183348

[sail, 2013-02-20 00:03:52]

https://codereview.chromium.org/12300036/diff/1/chrome/browser/profiles/profi...
File chrome/browser/profiles/profile_shortcut_manager_win.cc (right):

https://codereview.chromium.org/12300036/diff/1/chrome/browser/profiles/profi...
chrome/browser/profiles/profile_shortcut_manager_win.cc:623: if
(!cache.GetShortcutNameOfProfileAtIndex(profile_index).empty()) {
You already have UPDATE_EXISTING_ONLY and you pass the old shortcut name to
CreateOrUpdateDesktopShortcutsForProfile(). Can't you fix the bug there?

[Alexei Svitkine (slow), 2013-02-20 00:21:15]

https://codereview.chromium.org/12300036/diff/1/chrome/browser/profiles/profi...
File chrome/browser/profiles/profile_shortcut_manager_win.cc (right):

https://codereview.chromium.org/12300036/diff/1/chrome/browser/profiles/profi...
chrome/browser/profiles/profile_shortcut_manager_win.cc:623: if
(!cache.GetShortcutNameOfProfileAtIndex(profile_index).empty()) {
On 2013/02/20 00:03:52, sail wrote:
> You already have UPDATE_EXISTING_ONLY and you pass the old shortcut name to
> CreateOrUpdateDesktopShortcutsForProfile(). Can't you fix the bug there?

See the call in the "else if" in OnProfileAdded(). It needs to update existing
only, but including non-profile shortcuts. That's responsible for changing
Chromium.lnk to Chromium - First User.lnk on 2nd user creation, but only if
there's a Chromium.lnk (hence CREATE_WHEN_NONE_FOUND cannot be used there).

That call should still create Chromium - First User.lnk if there's a system
level Chromium.lnk.

[Alexei Svitkine (slow), 2013-02-20 00:50:40]

Updated to stick all the logic into CreateOrUpdateShortcutsForProfileAtPath()
per offline discussion.

[sail, 2013-02-20 00:56:40]

LGTM!

[commit-bot: I haz the power, 2013-02-20 01:00:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12300036/7001

[Alexei Svitkine (slow), 2013-02-20 01:03:06]

Committed patchset #2 manually as r183348 (presubmit successful).