Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 12300024: Change intermediate and output directories for 64bit VS build to different from x86 build. This su… (Closed)

Created:
7 years, 10 months ago by Will Harris
Modified:
7 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@allocator
Visibility:
Public.

Description

Change intermediate and output directories for 64bit VS build to different from x86 build. This supports issue 12303010 BUG=166496

Patch Set 1 #

Patch Set 2 : shorten line lengths a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Will Harris
This change makes the build output/intermediate directories for VS2010 builds to match those in Ninja ...
7 years, 10 months ago (2013-02-20 23:27:13 UTC) #1
scottmg
Hm, are we sure we shouldn't be getting rid of _x64 instead? -Dtarget_arch=x64 is how ...
7 years, 10 months ago (2013-02-20 23:32:42 UTC) #2
Will Harris
7 years, 10 months ago (2013-02-20 23:54:28 UTC) #3
On 2013/02/20 23:32:42, scottmg wrote:
> Hm, are we sure we shouldn't be getting rid of _x64 instead? -Dtarget_arch=x64
> is how the other platforms do it, which switches what Debug/Release are.

Decision was made not to make this change, instead to change
https://codereview.chromium.org/12303010/ to avoid having to detect platform
target by output directory name, and instead have this detected some other way

Powered by Google App Engine
This is Rietveld 408576698