Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1229953004: [Sync] Give custom themes priority over default themes (Closed)

Created:
5 years, 5 months ago by Nicolas Zea
Modified:
5 years, 5 months ago
Reviewers:
pkotwicz, pavely
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Give custom themes priority over default themes at signin time Previously a default theme could overwrite a custom theme if the default was already synced. Now, when a user signs in to sync on a new device, custom themes will have priority. BUG=440232 Committed: https://crrev.com/bee53729a8f430e4a8c92ec8a5bfc82952b50a27 Cr-Commit-Position: refs/heads/master@{#338398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/themes/theme_syncable_service.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Nicolas Zea
PTAL
5 years, 5 months ago (2015-07-10 00:40:58 UTC) #2
pavely
lgtm
5 years, 5 months ago (2015-07-10 17:51:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229953004/1
5 years, 5 months ago (2015-07-10 18:08:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/77907)
5 years, 5 months ago (2015-07-10 18:18:11 UTC) #7
Nicolas Zea
+Peter for owners
5 years, 5 months ago (2015-07-10 22:27:06 UTC) #9
pkotwicz
LGTM Can you please specify in the CL description what effect this CL has? My ...
5 years, 5 months ago (2015-07-10 23:35:42 UTC) #10
Nicolas Zea
On 2015/07/10 23:35:42, pkotwicz wrote: > LGTM > > Can you please specify in the ...
5 years, 5 months ago (2015-07-10 23:44:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229953004/1
5 years, 5 months ago (2015-07-10 23:44:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 23:50:56 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 23:51:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bee53729a8f430e4a8c92ec8a5bfc82952b50a27
Cr-Commit-Position: refs/heads/master@{#338398}

Powered by Google App Engine
This is Rietveld 408576698