Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/browser/themes/theme_syncable_service_unittest.cc

Issue 1229953004: [Sync] Give custom themes priority over default themes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/themes/theme_syncable_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_syncable_service_unittest.cc
diff --git a/chrome/browser/themes/theme_syncable_service_unittest.cc b/chrome/browser/themes/theme_syncable_service_unittest.cc
index ff0fd7ed917f5a8375e381dfcfe255501c3732eb..73ea15804739c039f42ad85604e53255b44d912f 100644
--- a/chrome/browser/themes/theme_syncable_service_unittest.cc
+++ b/chrome/browser/themes/theme_syncable_service_unittest.cc
@@ -306,7 +306,8 @@ TEST_F(ThemeSyncableServiceTest, SetCurrentThemeDefaultTheme) {
new syncer::SyncErrorFactoryMock()))
.error();
EXPECT_FALSE(error.IsSet()) << error.message();
- EXPECT_TRUE(fake_theme_service_->UsingDefaultTheme());
+ EXPECT_FALSE(fake_theme_service_->UsingDefaultTheme());
+ EXPECT_EQ(fake_theme_service_->theme_extension(), theme_extension_.get());
}
TEST_F(ThemeSyncableServiceTest, SetCurrentThemeSystemTheme) {
@@ -327,7 +328,8 @@ TEST_F(ThemeSyncableServiceTest, SetCurrentThemeSystemTheme) {
new syncer::SyncErrorFactoryMock()))
.error();
EXPECT_FALSE(error.IsSet()) << error.message();
- EXPECT_TRUE(fake_theme_service_->UsingSystemTheme());
+ EXPECT_FALSE(fake_theme_service_->UsingSystemTheme());
+ EXPECT_EQ(fake_theme_service_->theme_extension(), theme_extension_.get());
}
TEST_F(ThemeSyncableServiceTest, SetCurrentThemeCustomTheme) {
« no previous file with comments | « chrome/browser/themes/theme_syncable_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698