Source/core/html/HTMLBaseElement.h - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLBaseElement.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLBaseElement.h

diff --git a/Source/core/html/HTMLBaseElement.h b/Source/core/html/HTMLBaseElement.h

index 39c8bfeadffa2151eda6f88771a778e9c25f50b2..aefca42b4ef44b89cbf4f7d1f67858b43e98c35b 100644

--- a/Source/core/html/HTMLBaseElement.h

+++ b/Source/core/html/HTMLBaseElement.h

@@ -37,7 +37,7 @@ public:

private:

explicit HTMLBaseElement(Document&);

- virtual String target() const;

+ virtual AtomicString target() const OVERRIDE;

virtual bool isURLAttribute(const Attribute&) const OVERRIDE;

virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;

virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;

« no previous file with comments | « Source/core/html/HTMLAreaElement.cpp ('k') | Source/core/html/HTMLBaseElement.cpp » ('j') | no next file with comments »