Source/core/html/HTMLBaseElement.h - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLBaseElement.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/html/HTMLAreaElement.cpp ('k') | Source/core/html/HTMLBaseElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2009, 2010 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2009, 2010 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 19 matching lines...) Expand all Loading...
30 class HTMLBaseElement FINAL : public HTMLElement {	30 class HTMLBaseElement FINAL : public HTMLElement {

31 public:	31 public:

32 static PassRefPtr<HTMLBaseElement> create(Document&);	32 static PassRefPtr<HTMLBaseElement> create(Document&);

33	33

34 KURL href() const;	34 KURL href() const;

35 void setHref(const AtomicString&);	35 void setHref(const AtomicString&);

36	36

37 private:	37 private:

38 explicit HTMLBaseElement(Document&);	38 explicit HTMLBaseElement(Document&);

39	39

40 virtual String target() const;	40 virtual AtomicString target() const OVERRIDE;

41 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;	41 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;

42 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;	42 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;

43 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;	43 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;

44 virtual void removedFrom(ContainerNode*) OVERRIDE;	44 virtual void removedFrom(ContainerNode*) OVERRIDE;

45 };	45 };

46	46

47 } // namespace	47 } // namespace

48	48

49 #endif	49 #endif

OLD	NEW