Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1229883002: Skip Android SDK extras version check on bots (Closed)

Created:
5 years, 5 months ago by dgn
Modified:
5 years, 5 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip Android SDK extras version check on bots Bots have the sdk library delivered in a different way than the devs. The version they get is explicitely set in the build files while devs have to download the extras themselves. Running this check would not allow for example to download an already processed version of split client libraries BUG=490091 Committed: https://crrev.com/f3937ecb9f221c129a853ec11eb66dc68e095ad7 Cr-Commit-Position: refs/heads/master@{#338262}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M build/check_sdk_extras_version.py View 3 chunks +10 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
dgn
https://codereview.chromium.org/1229883002/diff/1/build/check_sdk_extras_version.py File build/check_sdk_extras_version.py (right): https://codereview.chromium.org/1229883002/diff/1/build/check_sdk_extras_version.py#newcode78 build/check_sdk_extras_version.py:78: colorama.Style.RESET_ALL) Only the color was previously reset, the rest ...
5 years, 5 months ago (2015-07-09 15:30:10 UTC) #2
cjhopman
lgtm
5 years, 5 months ago (2015-07-10 02:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229883002/1
5 years, 5 months ago (2015-07-10 08:40:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 08:49:26 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 08:50:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3937ecb9f221c129a853ec11eb66dc68e095ad7
Cr-Commit-Position: refs/heads/master@{#338262}

Powered by Google App Engine
This is Rietveld 408576698