Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: build/check_sdk_extras_version.py

Issue 1229883002: Skip Android SDK extras version check on bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_sdk_extras_version.py
diff --git a/build/check_sdk_extras_version.py b/build/check_sdk_extras_version.py
index 7488f8b940d787853b561a2633a4f1dbae02aafc..9b2f10d2abc038940bd48b7aa8c2f740c652e1bb 100755
--- a/build/check_sdk_extras_version.py
+++ b/build/check_sdk_extras_version.py
@@ -62,8 +62,9 @@ def main():
args = parser.parse_args()
- minimum_version = GetRequiredMinimumVersion(args.package_id)
- CheckPackageVersion(args.package_id, args.package_location, minimum_version)
+ if not ShouldSkipVersionCheck():
+ minimum_version = GetRequiredMinimumVersion(args.package_id)
+ CheckPackageVersion(args.package_id, args.package_location, minimum_version)
# Create the stamp file.
if args.stamp:
@@ -74,7 +75,7 @@ def main():
def ExitError(msg):
sys.exit(colorama.Fore.MAGENTA + colorama.Style.BRIGHT + msg +
- colorama.Fore.RESET)
+ colorama.Style.RESET_ALL)
dgn 2015/07/09 15:30:10 Only the color was previously reset, the rest of t
def GetRequiredMinimumVersion(package_id):
@@ -119,6 +120,12 @@ def CheckPackageVersion(pkg_id, location, minimum_version):
# Everything looks ok, print nothing.
+def ShouldSkipVersionCheck():
+ '''
+ Bots should not run the version check, since they download the sdk extras
+ in a different way.
+ '''
+ return bool(os.environ.get('CHROME_HEADLESS'))
if __name__ == '__main__':
main()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698