roll clang 239765:241602

roll clang 239765:241602

This will hopefully fix symbolization on the asan/android bots.

This also brings in somewhat major changes in how the asan runtime is
built on OS X; hopefully it won't break the mac asan bots.

libcxx(abi) grew CMake files, which is great – except it adds the libcxx(abi)
tests to `check-all`, and they don't pass in bootstrap mode on OS X.
So delete libcxx(abi) before starting the main build. (It's only needed on OS X
for bundling libcxx with the compiler so it can run on 10.6, and that's all done
after the first build.)

This also adds support for __nullable and Objective-C generics.

BUG=502974, 499448
TBR=hans
NOPRESUBMIT=true

Committed: https://crrev.com/dd2dc4c908b9c05b33a1aa54761603f9f5bf96f5
Cr-Commit-Position: refs/heads/master@{#338220}

[Nico, 2015-07-09 22:52:45]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[Nico, 2015-07-10 02:24:22]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-07-10 02:25:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229653005/130001

[commit-bot: I haz the power, 2015-07-10 02:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 02:33:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-07-10 02:40:55]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-07-10 02:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229653005/130001

[commit-bot: I haz the power, 2015-07-10 02:42:43]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2015-07-10 02:44:25]

Patchset 8 (id:??) landed as
https://crrev.com/dd2dc4c908b9c05b33a1aa54761603f9f5bf96f5
Cr-Commit-Position: refs/heads/master@{#338220}

[Michael Achenbach, 2015-07-13 12:02:32]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2015-07-13 12:02:33]

FYI: Looks like this clang roll breaks the asan 32 bit builders with arm v8,
e.g.:
http://build.chromium.org/p/chromium.lkgr/builders/ASan%20Debug%20%2832-bit%2...

Are there more changes in common.gypi needed?

[Alexander Potapenko, 2015-07-13 12:14:50]

glider@chromium.org changed reviewers:
+ glider@chromium.org

[Alexander Potapenko, 2015-07-13 12:14:51]

Maybe the 32-bit runtime is just missing from the Goma package?

[Nico, 2015-07-13 15:10:10]

On 2015/07/13 12:14:51, Alexander Potapenko wrote:
> Maybe the 32-bit runtime is just missing from the Goma package?

Linking is done locally, not on goma. But it does look like the 32-bit
compiler-rt runtime is missing from the linux package. I'll look at this today.

glider: I'm just doing a regular build of compiler-rt. I thought this used to
build both 32-bit and 64-bit asan runtimes. Has this changed?

[Alexander Potapenko, 2015-07-13 15:22:12]

On 2015/07/13 15:10:10, Nico wrote:
> On 2015/07/13 12:14:51, Alexander Potapenko wrote:
> > Maybe the 32-bit runtime is just missing from the Goma package?
> 
> Linking is done locally, not on goma. But it does look like the 32-bit
> compiler-rt runtime is missing from the linux package. I'll look at this
today.
> 
> glider: I'm just doing a regular build of compiler-rt. I thought this used to
> build both 32-bit and 64-bit asan runtimes. Has this changed?

I've ran `make check-asan` in a local Clang checkout and got the following libs:

$ ls lib/clang/3.7.0/lib/linux/libclang_rt.
libclang_rt.asan_cxx-i386.a         libclang_rt.asan-preinit-i686.a
libclang_rt.asan_cxx-i686.a         libclang_rt.asan-preinit-x86_64.a
libclang_rt.asan_cxx-x86_64.a       libclang_rt.asan-x86_64.a
libclang_rt.asan_cxx-x86_64.a.syms  libclang_rt.asan-x86_64.a.syms
libclang_rt.asan-i386.a             libclang_rt.asan-x86_64.so
libclang_rt.asan-i386.so            libclang_rt.profile-i386.a
libclang_rt.asan-i686.a             libclang_rt.profile-i686.a
libclang_rt.asan-i686.so            libclang_rt.profile-x86_64.a
libclang_rt.asan-preinit-i386.a     


So everything seems to be fine.

[Nico, 2015-07-13 15:26:08]

On 2015/07/13 15:22:12, Alexander Potapenko wrote:
> On 2015/07/13 15:10:10, Nico wrote:
> > On 2015/07/13 12:14:51, Alexander Potapenko wrote:
> > > Maybe the 32-bit runtime is just missing from the Goma package?
> > 
> > Linking is done locally, not on goma. But it does look like the 32-bit
> > compiler-rt runtime is missing from the linux package. I'll look at this
> today.
> > 
> > glider: I'm just doing a regular build of compiler-rt. I thought this used
to
> > build both 32-bit and 64-bit asan runtimes. Has this changed?
> 
> I've ran `make check-asan` in a local Clang checkout and got the following
libs:
> 
> $ ls lib/clang/3.7.0/lib/linux/libclang_rt.
> libclang_rt.asan_cxx-i386.a         libclang_rt.asan-preinit-i686.a
> libclang_rt.asan_cxx-i686.a         libclang_rt.asan-preinit-x86_64.a
> libclang_rt.asan_cxx-x86_64.a       libclang_rt.asan-x86_64.a
> libclang_rt.asan_cxx-x86_64.a.syms  libclang_rt.asan-x86_64.a.syms
> libclang_rt.asan-i386.a             libclang_rt.asan-x86_64.so
> libclang_rt.asan-i386.so            libclang_rt.profile-i386.a
> libclang_rt.asan-i686.a             libclang_rt.profile-i686.a
> libclang_rt.asan-i686.so            libclang_rt.profile-x86_64.a
> libclang_rt.asan-preinit-i386.a     
> 
> 
> So everything seems to be fine.

Do I need any local packages installed for the 32-bit runtime to be built?

[Nico, 2015-07-13 15:31:39]

On 2015/07/13 15:26:08, Nico wrote:
> On 2015/07/13 15:22:12, Alexander Potapenko wrote:
> > On 2015/07/13 15:10:10, Nico wrote:
> > > On 2015/07/13 12:14:51, Alexander Potapenko wrote:
> > > > Maybe the 32-bit runtime is just missing from the Goma package?
> > > 
> > > Linking is done locally, not on goma. But it does look like the 32-bit
> > > compiler-rt runtime is missing from the linux package. I'll look at this
> > today.
> > > 
> > > glider: I'm just doing a regular build of compiler-rt. I thought this used
> to
> > > build both 32-bit and 64-bit asan runtimes. Has this changed?
> > 
> > I've ran `make check-asan` in a local Clang checkout and got the following
> libs:
> > 
> > $ ls lib/clang/3.7.0/lib/linux/libclang_rt.
> > libclang_rt.asan_cxx-i386.a         libclang_rt.asan-preinit-i686.a
> > libclang_rt.asan_cxx-i686.a         libclang_rt.asan-preinit-x86_64.a
> > libclang_rt.asan_cxx-x86_64.a       libclang_rt.asan-x86_64.a
> > libclang_rt.asan_cxx-x86_64.a.syms  libclang_rt.asan-x86_64.a.syms
> > libclang_rt.asan-i386.a             libclang_rt.asan-x86_64.so
> > libclang_rt.asan-i386.so            libclang_rt.profile-i386.a
> > libclang_rt.asan-i686.a             libclang_rt.profile-i686.a
> > libclang_rt.asan-i686.so            libclang_rt.profile-x86_64.a
> > libclang_rt.asan-preinit-i386.a     
> > 
> > 
> > So everything seems to be fine.
> 
> Do I need any local packages installed for the 32-bit runtime to be built?

cmake/config-ix.cmake has 

# test_target_arch(<arch> <def> <target flags...>)
# Checks if architecture is supported: runs host compiler with provided
# flags to verify that:
#   1) <def> is defined (if non-empty)
#   2) simple file can be successfully built.
# If successful, saves target flags for this architecture.
macro(test_target_arch arch def)

I guess that fails on my new VM for some reason and the build silently fails…

[Alexander Potapenko, 2015-07-13 15:32:03]

On 2015/07/13 15:26:08, Nico wrote:
> On 2015/07/13 15:22:12, Alexander Potapenko wrote:
> > On 2015/07/13 15:10:10, Nico wrote:
> > > On 2015/07/13 12:14:51, Alexander Potapenko wrote:
> > > > Maybe the 32-bit runtime is just missing from the Goma package?
> > > 
> > > Linking is done locally, not on goma. But it does look like the 32-bit
> > > compiler-rt runtime is missing from the linux package. I'll look at this
> > today.
> > > 
> > > glider: I'm just doing a regular build of compiler-rt. I thought this used
> to
> > > build both 32-bit and 64-bit asan runtimes. Has this changed?
> > 
> > I've ran `make check-asan` in a local Clang checkout and got the following
> libs:
> > 
> > $ ls lib/clang/3.7.0/lib/linux/libclang_rt.
> > libclang_rt.asan_cxx-i386.a         libclang_rt.asan-preinit-i686.a
> > libclang_rt.asan_cxx-i686.a         libclang_rt.asan-preinit-x86_64.a
> > libclang_rt.asan_cxx-x86_64.a       libclang_rt.asan-x86_64.a
> > libclang_rt.asan_cxx-x86_64.a.syms  libclang_rt.asan-x86_64.a.syms
> > libclang_rt.asan-i386.a             libclang_rt.asan-x86_64.so
> > libclang_rt.asan-i386.so            libclang_rt.profile-i386.a
> > libclang_rt.asan-i686.a             libclang_rt.profile-i686.a
> > libclang_rt.asan-i686.so            libclang_rt.profile-x86_64.a
> > libclang_rt.asan-preinit-i386.a     
> > 
> > 
> > So everything seems to be fine.
> 
> Do I need any local packages installed for the 32-bit runtime to be built?

Don't think so. My machine is one month old, and I haven't installed anything
not related to Chrome.

[Nico, 2015-07-13 15:35:46]

On 2015/07/13 15:31:39, Nico wrote:
> On 2015/07/13 15:26:08, Nico wrote:
> > On 2015/07/13 15:22:12, Alexander Potapenko wrote:
> > > On 2015/07/13 15:10:10, Nico wrote:
> > > > On 2015/07/13 12:14:51, Alexander Potapenko wrote:
> > > > > Maybe the 32-bit runtime is just missing from the Goma package?
> > > > 
> > > > Linking is done locally, not on goma. But it does look like the 32-bit
> > > > compiler-rt runtime is missing from the linux package. I'll look at this
> > > today.
> > > > 
> > > > glider: I'm just doing a regular build of compiler-rt. I thought this
used
> > to
> > > > build both 32-bit and 64-bit asan runtimes. Has this changed?
> > > 
> > > I've ran `make check-asan` in a local Clang checkout and got the following
> > libs:
> > > 
> > > $ ls lib/clang/3.7.0/lib/linux/libclang_rt.
> > > libclang_rt.asan_cxx-i386.a         libclang_rt.asan-preinit-i686.a
> > > libclang_rt.asan_cxx-i686.a         libclang_rt.asan-preinit-x86_64.a
> > > libclang_rt.asan_cxx-x86_64.a       libclang_rt.asan-x86_64.a
> > > libclang_rt.asan_cxx-x86_64.a.syms  libclang_rt.asan-x86_64.a.syms
> > > libclang_rt.asan-i386.a             libclang_rt.asan-x86_64.so
> > > libclang_rt.asan-i386.so            libclang_rt.profile-i386.a
> > > libclang_rt.asan-i686.a             libclang_rt.profile-i686.a
> > > libclang_rt.asan-i686.so            libclang_rt.profile-x86_64.a
> > > libclang_rt.asan-preinit-i386.a     
> > > 
> > > 
> > > So everything seems to be fine.
> > 
> > Do I need any local packages installed for the 32-bit runtime to be built?
> 
> cmake/config-ix.cmake has 
> 
> # test_target_arch(<arch> <def> <target flags...>)
> # Checks if architecture is supported: runs host compiler with provided
> # flags to verify that:
> #   1) <def> is defined (if non-empty)
> #   2) simple file can be successfully built.
> # If successful, saves target flags for this architecture.
> macro(test_target_arch arch def)
> 
> I guess that fails on my new VM for some reason and the build silently fails…

In my VM:

thakis@thakis-VirtualBox:~/chrome-src$ cat test.cc
#include <stdlib.h>
#include <limits>
int main() {}
thakis@thakis-VirtualBox:~/chrome-src$
third_party/llvm-bootstrap-install/bin/clang -c -m32 test.cc
In file included from test.cc:1:
In file included from /usr/include/stdlib.h:25:
/usr/include/features.h:324:10: fatal error: 'bits/predefs.h' file not found
#include <bits/predefs.h>
         ^
1 error generated.
thakis@thakis-VirtualBox:~/chrome-src$ gcc -c -m32 test.ccIn file included from
/usr/include/stdlib.h:25:0,
                 from test.cc:1:
/usr/include/features.h:324:26: fatal error: bits/predefs.h: No such file or
directory
compilation terminated.


So that explains why 32-bit asan wasn't built, I suppose.

[Nico, 2015-07-13 15:38:08]

I ran

 sudo apt-get install g++-multilib

Now trying again.

[eugenis, 2015-07-13 15:47:16]

On 2015/07/13 15:38:08, Nico wrote:
> I ran
> 
>  sudo apt-get install g++-multilib
> 
> Now trying again.

No idea if it's related, but these failures started at around the time of this
roll:
https://code.google.com/p/chromium/issues/detail?id=508949

[Nico, 2015-07-13 17:46:24]

New package with a 32-bit asan runtime:
https://codereview.chromium.org/1235883006/

On 2015/07/13 15:47:16, eugenis wrote:
> On 2015/07/13 15:38:08, Nico wrote:
> > I ran
> > 
> >  sudo apt-get install g++-multilib
> > 
> > Now trying again.
> 
> No idea if it's related, but these failures started at around the time of this
> roll:
> https://code.google.com/p/chromium/issues/detail?id=508949

Keep me posted :-/

[hans, 2015-07-13 17:49:51]

On 2015/07/13 17:46:24, Nico wrote:
> New package with a 32-bit asan runtime:
> https://codereview.chromium.org/1235883006/

lgtm