Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: tools/clang/scripts/update.py

Issue 1229653005: roll clang 239765:241602 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gnbleh Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/scripts/package.py ('k') | tools/clang/scripts/update.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index f695ad4681a4b8309793ae69e5d8ddf2bf1f23ee..745dbdf5083c9f4434e6ec1f3bed1a37fdf99d20 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -221,6 +221,7 @@ def RevertPreviouslyPatchedFiles():
'%(compiler_rt)s/test/tsan/signal_segv_handler.cc',
'%(compiler_rt)s/lib/sanitizer_common/sanitizer_coverage_libcdep.cc',
'%(compiler_rt)s/cmake/config-ix.cmake',
+ '%(compiler_rt)s/CMakeLists.txt',
'%(compiler_rt)s/lib/ubsan/ubsan_platform.h',
]
for f in files:
@@ -282,30 +283,16 @@ def ApplyLocalPatches():
# The UBSan run-time, which is now bundled with the ASan run-time, doesn't
# work on Mac OS X 10.8 (PR23539).
compiler_rt_patches = [ r"""\
---- cmake/config-ix.cmake
-+++ cmake/config-ix.cmake
-@@ -319,7 +319,7 @@ else()
- endif()
-
- if (COMPILER_RT_HAS_SANITIZER_COMMON AND UBSAN_SUPPORTED_ARCH AND
-- OS_NAME MATCHES "Darwin|Linux|FreeBSD")
-+ OS_NAME MATCHES "Linux|FreeBSD")
- set(COMPILER_RT_HAS_UBSAN TRUE)
- else()
- set(COMPILER_RT_HAS_UBSAN FALSE)
-diff --git a/lib/ubsan/ubsan_platform.h b/lib/ubsan/ubsan_platform.h
-index 8ba253b..d5dce8d 100644
---- lib/ubsan/ubsan_platform.h
-+++ lib/ubsan/ubsan_platform.h
-@@ -14,7 +14,7 @@
- #define UBSAN_PLATFORM_H
-
- // Other platforms should be easy to add, and probably work as-is.
--#if (defined(__linux__) || defined(__FreeBSD__) || defined(__APPLE__)) && \
-+#if (defined(__linux__) || defined(__FreeBSD__)) && \
- (defined(__x86_64__) || defined(__i386__) || defined(__arm__) || \
- defined(__aarch64__) || defined(__mips__) || defined(__powerpc64__))
- # define CAN_SANITIZE_UB 1
+--- CMakeLists.txt (revision 241602)
++++ CMakeLists.txt (working copy)
+@@ -305,6 +305,7 @@
+ list(APPEND SANITIZER_COMMON_SUPPORTED_OS iossim)
+ endif()
+ endif()
++ set(SANITIZER_MIN_OSX_VERSION "10.7")
+ if(SANITIZER_MIN_OSX_VERSION VERSION_LESS "10.7")
+ message(FATAL_ERROR "Too old OS X version: ${SANITIZER_MIN_OSX_VERSION}")
+ endif()
"""
]
@@ -538,6 +525,18 @@ def UpdateClang(args):
os.symlink('libc++.1.dylib', 'libc++.dylib')
ldflags += ['-stdlib=libc++', '-L' + libcxxbuild]
+ if args.bootstrap:
+ # Now that the libc++ headers have been installed and libc++.dylib is
+ # built, delete the libc++ checkout again so that it's not part of the
+ # main build below -- the libc++(abi) tests don't pass on OS X in
+ # bootstrap builds (http://llvm.org/PR24068)
+ RmTree(LIBCXX_DIR)
+ RmTree(LIBCXXABI_DIR)
+ cxxflags = ['-stdlib=libc++', '-nostdinc++',
+ '-I' + os.path.join(LLVM_BOOTSTRAP_INSTALL_DIR,
+ 'include/c++/v1')
+ ] + cflags
+
# Build clang.
binutils_incdir = ''
if sys.platform.startswith('linux'):
« no previous file with comments | « tools/clang/scripts/package.py ('k') | tools/clang/scripts/update.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698