Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

Issue 12294028: Fix warnings spotted by dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart b/dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
index 886d39e2f1bcdd7ccc66acfe255566e334fd3d12..9acc6ec13e225332e66d881b4c679e3a2c38955a 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
@@ -89,15 +89,15 @@ void renamePlaceholders(
StringBuffer result = new StringBuffer(renameElement(type.element));
if (type is InterfaceType) {
if (!type.isRaw) {
- result.add('<');
+ result.write('<');
Link<DartType> argumentsLink = type.typeArguments;
- result.add(renameType(argumentsLink.head, renameElement));
+ result.write(renameType(argumentsLink.head, renameElement));
for (Link<DartType> link = argumentsLink.tail; !link.isEmpty;
link = link.tail) {
- result.add(',');
- result.add(renameType(link.head, renameElement));
+ result.write(',');
+ result.write(renameType(link.head, renameElement));
}
- result.add('>');
+ result.write('>');
}
}
return result.toString();
@@ -112,8 +112,8 @@ void renamePlaceholders(
// Named constructor or factory. Is there a more reliable way to check
// this case?
if (!placeholder.isRedirectingCall) {
- result.add(renameType(placeholder.type, renameElement));
- result.add('.');
+ result.write(renameType(placeholder.type, renameElement));
+ result.write('.');
}
String prefix = '${element.getEnclosingClass().name.slowToString()}\$';
if (!name.startsWith(prefix)) {
@@ -125,10 +125,10 @@ void renamePlaceholders(
if (!element.getLibrary().isPlatformLibrary) {
name = renameString(element.getLibrary(), name);
}
- result.add(name);
+ result.write(name);
} else {
assert(!placeholder.isRedirectingCall);
- result.add(renameType(placeholder.type, renameElement));
+ result.write(renameType(placeholder.type, renameElement));
}
return result.toString();
}
@@ -346,14 +346,14 @@ class MinifyingGenerator {
int index = nextIdIndex++;
StringBuffer resultBuilder = new StringBuffer();
if (index < firstCharAlphabet.length) return firstCharAlphabet[index];
- resultBuilder.add(firstCharAlphabet[index % firstCharAlphabet.length]);
+ resultBuilder.write(firstCharAlphabet[index % firstCharAlphabet.length]);
index ~/= firstCharAlphabet.length;
int length = otherCharsAlphabet.length;
while (index >= length) {
- resultBuilder.add(otherCharsAlphabet[index % length]);
+ resultBuilder.write(otherCharsAlphabet[index % length]);
index ~/= length;
}
- resultBuilder.add(otherCharsAlphabet[index]);
+ resultBuilder.write(otherCharsAlphabet[index]);
return resultBuilder.toString();
}
}

Powered by Google App Engine
This is Rietveld 408576698