Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: test/dependency_computer/cycle_test.dart

Issue 1229303004: Fix a stack overflow when loading transformers. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/dependency_computer/cycle_test.dart
diff --git a/test/dependency_computer/cycle_test.dart b/test/dependency_computer/cycle_test.dart
index 39652507d185ffc5e56e62db0ae4bcb2eb7516e0..f93f475581e5315cae18314b8e2710ca3b935fdc 100644
--- a/test/dependency_computer/cycle_test.dart
+++ b/test/dependency_computer/cycle_test.dart
@@ -205,4 +205,22 @@ void main() {
expectDependencies({'myapp': []});
});
+
+ // Regression test for #1298
+ integration("allows a single-package import cycle with two uses of "
+ "the same transformer", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "transformers": ["myapp", "myapp"]
+ }),
+ d.dir('lib', [
+ d.file("myapp.dart", transformer(['foo.dart'])),
+ d.file("foo.dart", "import 'bar.dart';"),
+ d.file("bar.dart", "import 'myapp.dart';"),
+ ])
+ ]).create();
+
+ expectDependencies({'myapp': []});
+ });
}
« no previous file with comments | « lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698