Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: test/dependency_computer/cycle_test.dart

Issue 1229303004: Fix a stack overflow when loading transformers. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library pub_tests; 5 library pub_tests;
6 6
7 import '../descriptor.dart' as d; 7 import '../descriptor.dart' as d;
8 import '../test_pub.dart'; 8 import '../test_pub.dart';
9 import 'utils.dart'; 9 import 'utils.dart';
10 10
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 }), 198 }),
199 d.dir('lib', [ 199 d.dir('lib', [
200 d.file("myapp.dart", transformer(['foo.dart'])), 200 d.file("myapp.dart", transformer(['foo.dart'])),
201 d.file("foo.dart", "import 'bar.dart';"), 201 d.file("foo.dart", "import 'bar.dart';"),
202 d.file("bar.dart", "import 'myapp.dart';"), 202 d.file("bar.dart", "import 'myapp.dart';"),
203 ]) 203 ])
204 ]).create(); 204 ]).create();
205 205
206 expectDependencies({'myapp': []}); 206 expectDependencies({'myapp': []});
207 }); 207 });
208
209 // Regression test for #1298
210 integration("allows a single-package import cycle with two uses of "
211 "the same transformer", () {
212 d.dir(appPath, [
213 d.pubspec({
214 "name": "myapp",
215 "transformers": ["myapp", "myapp"]
216 }),
217 d.dir('lib', [
218 d.file("myapp.dart", transformer(['foo.dart'])),
219 d.file("foo.dart", "import 'bar.dart';"),
220 d.file("bar.dart", "import 'myapp.dart';"),
221 ])
222 ]).create();
223
224 expectDependencies({'myapp': []});
225 });
208 } 226 }
OLDNEW
« no previous file with comments | « lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698