chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed first review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index a157c7457ef7d94933d847fb0e09a3131a0370ef..3f71abf3ab608c7cc8962d276f99d7595382da8f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -17,6 +17,11 @@ public interface AppMenuPropertiesDelegate {

boolean shouldShowAppMenu();

/**

+ * @return Resource layout id for the footer if there should be one. O otherwise.

+ */

+ int getFooterResourceId();

+ /**

* Allows the delegate to show and hide items before the App Menu is shown.

* @param mMenu Menu that will be used as the source for the App Menu pop up.