chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed first review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

index 0ccfa08585ec46aef68badb62198163a4bf158a4..29943fa503146f847591d358529958d1db0405b1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

@@ -116,9 +116,8 @@ public class AppMenuHandler {

int rotation = mActivity.getWindowManager().getDefaultDisplay().getRotation();

Point pt = new Point();

mActivity.getWindowManager().getDefaultDisplay().getSize(pt);

- mAppMenu.show(

- wrapper, anchorView, isByHardwareButton, rotation, appRect, pt.y);

+ mAppMenu.show(wrapper, anchorView, isByHardwareButton,

+ rotation, appRect, pt.y, mDelegate.getFooterResourceId());

mAppMenuDragHelper.onShow(startDragging);

RecordUserAction.record("MobileMenuShow");

return true;