Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/android/java/res/layout/chrome_branding_footer.xml

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/chrome_branding_footer.xml
diff --git a/chrome/android/java/res/layout/item_chooser_dialog_row.xml b/chrome/android/java/res/layout/chrome_branding_footer.xml
similarity index 60%
copy from chrome/android/java/res/layout/item_chooser_dialog_row.xml
copy to chrome/android/java/res/layout/chrome_branding_footer.xml
index f36586a3aeef43f02463257c0e7302dfeb85147c..fc24d1877e0650577233be9d732efb9812eda7dc 100644
--- a/chrome/android/java/res/layout/item_chooser_dialog_row.xml
+++ b/chrome/android/java/res/layout/chrome_branding_footer.xml
@@ -5,9 +5,12 @@
<TextView xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
- android:layout_height="48dp"
+ android:layout_height="@dimen/chrome_branding_footer_height"
newt (away) 2015/07/10 16:08:38 Does this look OK when the font size is set to Hug
Yusuf 2015/07/10 18:43:47 I think it does. Screenshot uploaded to bug.
android:paddingStart="16dp"
android:paddingEnd="16dp"
- android:ellipsize="end"
- android:gravity="center_vertical"
+ android:background="@drawable/bg_menu_chrome_branding"
+ android:gravity="start|center_vertical"
+ android:textSize="12sp"
+ android:textColor="#616161"
newt (away) 2015/07/10 16:08:38 Another shade of gray! (Not your fault. But please
Yusuf 2015/07/10 18:43:47 Done. Well not done, but put it on my list. :)
+ android:text="@string/chrome_branding_message"
android:singleLine="true" />

Powered by Google App Engine
This is Rietveld 408576698