chrome/android/java/res/layout/chrome_branding_footer.xml - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/chrome_branding_footer.xml

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/drawable/bg_menu_chrome_branding.xml ('K') | « chrome/android/java/res/drawable/bg_menu_chrome_branding.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2015/07/10 16:08:38 I'd suggest calling this powered_by_chrome.xml or I'd suggest calling this powered_by_chrome.xml or powered_by_chrome_footer.xml. "chrome_branding" is a big vaguer and could mean a lot of things. (If you change the name, please update the other resource names too) Yusuf 2015/07/10 18:43:47 Done. Show quoted text On 2015/07/10 16:08:38, newt wrote: > I'd suggest calling this powered_by_chrome.xml or powered_by_chrome_footer.xml. > "chrome_branding" is a big vaguer and could mean a lot of things. (If you change > the name, please update the other resource names too) Done.
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <TextView xmlns:android="http://schemas.android.com/apk/res/android"	6 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

7 android:layout_width="match_parent"	7 android:layout_width="match_parent"

8 android:layout_height="48dp"	8 android:layout_height="@dimen/chrome_branding_footer_height"
	newt (away) 2015/07/10 16:08:38 Does this look OK when the font size is set to Hug Does this look OK when the font size is set to Huge? If not, you might want to use wrap_content. Yusuf 2015/07/10 18:43:47 I think it does. Screenshot uploaded to bug. Show quoted text On 2015/07/10 16:08:38, newt wrote: > Does this look OK when the font size is set to Huge? If not, you might want to > use wrap_content. I think it does. Screenshot uploaded to bug.
9 android:paddingStart="16dp"	9 android:paddingStart="16dp"

10 android:paddingEnd="16dp"	10 android:paddingEnd="16dp"

11 android:ellipsize="end"	11 android:background="@drawable/bg_menu_chrome_branding"

12 android:gravity="center_vertical"	12 android:gravity="start\|center_vertical"

	13 android:textSize="12sp"

	14 android:textColor="#616161"
	newt (away) 2015/07/10 16:08:38 Another shade of gray! (Not your fault. But please Another shade of gray! (Not your fault. But please make the designer feel guilty for this.) Yusuf 2015/07/10 18:43:47 Done. Well not done, but put it on my list. :) Show quoted text On 2015/07/10 16:08:38, newt wrote: > Another shade of gray! (Not your fault. But please make the designer feel guilty > for this.) Done. Well not done, but put it on my list. :)
	15 android:text="@string/chrome_branding_message"

13 android:singleLine="true" />	16 android:singleLine="true" />

OLD	NEW