Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229143007: Start to propagate constness of GrPipelineBuilder up the stack (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@const-fix
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start to propagate constness of GrPipelineBuilder up the stack BUG=skia: Committed: https://skia.googlesource.com/skia/+/1c735488cbec9abdb25c9a12e0c11af9c302a776

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -106 lines) Patch
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/constcolorprocessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrDashLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 9 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 9 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 12 chunks +22 lines, -27 lines 0 comments Download
M src/gpu/GrGpu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-10 17:03:30 UTC) #2
robertphillips
lgtm
5 years, 5 months ago (2015-07-10 20:34:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229143007/20001
5 years, 5 months ago (2015-07-13 14:39:04 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:08:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1c735488cbec9abdb25c9a12e0c11af9c302a776

Powered by Google App Engine
This is Rietveld 408576698