Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 1229133004: Add SelectionMode enum for setRangeText() in HTMLInputElement and HTMLTextAreaElement (Closed)

Created:
5 years, 5 months ago by tanay.c
Modified:
5 years, 5 months ago
Reviewers:
philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add SelectionMode enum for setRangeText() in HTMLInputElement and HTMLTextAreaElement In FF invalid SelectionMode values throw TypeError In IE 'setRangeText' method is not supported BUG=508304 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199316

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix for failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M LayoutTests/fast/forms/resources/common-setrangetext.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/search/search-setrangetext-expected.txt View 1 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/forms/setrangetext-expected.txt View 1 5 chunks +20 lines, -20 lines 0 comments Download
M LayoutTests/fast/forms/textarea/textarea-setrangetext-expected.txt View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
tanay.c
Please have a look.
5 years, 5 months ago (2015-07-21 05:44:51 UTC) #2
tanay.c
Please have a look.
5 years, 5 months ago (2015-07-21 05:45:20 UTC) #3
philipj_slow
Please test this in Firefox and IE and document their behavior in the description, making ...
5 years, 5 months ago (2015-07-21 07:34:21 UTC) #4
tanay.c
On 2015/07/21 07:34:21, philipj wrote: > Please test this in Firefox and IE and document ...
5 years, 5 months ago (2015-07-21 10:53:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229133004/40001
5 years, 5 months ago (2015-07-21 11:19:03 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/51646)
5 years, 5 months ago (2015-07-21 12:38:42 UTC) #9
philipj_slow
Looks like there are some real test failures, please investigate :)
5 years, 5 months ago (2015-07-21 12:55:06 UTC) #10
tanay.c
On 2015/07/21 12:55:06, philipj wrote: > Looks like there are some real test failures, please ...
5 years, 5 months ago (2015-07-22 13:41:17 UTC) #11
philipj_slow
lgtm
5 years, 5 months ago (2015-07-22 14:43:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229133004/60001
5 years, 5 months ago (2015-07-22 14:44:14 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 16:07:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199316

Powered by Google App Engine
This is Rietveld 408576698