Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: Source/core/html/HTMLTextAreaElement.idl

Issue 1229133004: Add SelectionMode enum for setRangeText() in HTMLInputElement and HTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix for failing tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.idl ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextAreaElement.idl
diff --git a/Source/core/html/HTMLTextAreaElement.idl b/Source/core/html/HTMLTextAreaElement.idl
index a937807268b0636357fda157ef961f83db658016..ea7ca760f41738b09f32065c1b6f22482c9260d9 100644
--- a/Source/core/html/HTMLTextAreaElement.idl
+++ b/Source/core/html/HTMLTextAreaElement.idl
@@ -58,11 +58,10 @@ interface HTMLTextAreaElement : HTMLElement {
attribute long selectionEnd;
attribute DOMString selectionDirection;
[RaisesException] void setRangeText(DOMString replacement);
- // TODO(philipj): The selectionMode argument should be a SelectionMode enum.
[RaisesException] void setRangeText(DOMString replacement,
unsigned long start,
unsigned long end,
- optional DOMString selectionMode = null);
+ optional SelectionMode selectionMode = "preserve");
// TODO(philipj): The start and end arguments should be unsigned long and
// should not be optional.
void setSelectionRange([Default=Undefined] optional long start,
« no previous file with comments | « Source/core/html/HTMLInputElement.idl ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698