Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: content/public/browser/render_process_host_observer.h

Issue 1228993005: Be a little more precise in the wording of comments for process death. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host_observer.h
diff --git a/content/public/browser/render_process_host_observer.h b/content/public/browser/render_process_host_observer.h
index 926b66d1dd3dd252bac3209d89e553faa781575b..b9a7a3df376e59419c54a4cdd4e393eb43ddffb5 100644
--- a/content/public/browser/render_process_host_observer.h
+++ b/content/public/browser/render_process_host_observer.h
@@ -17,11 +17,13 @@ class RenderProcessHost;
// in RenderProcessHost lifecycle events.
class CONTENT_EXPORT RenderProcessHostObserver {
public:
- // This method is invoked when a render process exited (either normally or
- // with a crash). To determine if the process closed normally or crashed,
- // examine the |status| parameter.
+ // This method is invoked when the process of the observed RenderProcessHost
+ // exits (either normally or with a crash). To determine if the process closed
+ // normally or crashed, examine the |status| parameter.
//
- // Note that this is equivalent to WebContentsObserver::RenderProcessGone().
+ // This will cause a call to WebContentsObserver::RenderProcessGone() for
+ // active renderer processes; for code that needs to be a WebContentsObserver
nasko 2015/07/10 07:48:54 This isn't quite correct I think. Last time I poke
Avi (use Gerrit) 2015/07/10 15:29:20 I see that. WebContentsImpl::RenderViewTerminated
+ // anyway, consider whether that API might be a better choice.
virtual void RenderProcessExited(RenderProcessHost* host,
base::TerminationStatus status,
int exit_code) {}

Powered by Google App Engine
This is Rietveld 408576698