Chromium Code Reviews| Index: content/public/browser/web_contents_observer.h |
| diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h |
| index 501b94efb0c95f2c5f357ab95e6d74740f66aabd..0f87a0dcfaf0ac23ef9cb756464cf80a72310a38 100644 |
| --- a/content/public/browser/web_contents_observer.h |
| +++ b/content/public/browser/web_contents_observer.h |
| @@ -97,13 +97,16 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener, |
| // just swapped out. |
| virtual void RenderViewDeleted(RenderViewHost* render_view_host) {} |
| - // This method is invoked when the process for the current RenderView crashes. |
| - // The WebContents continues to use the RenderViewHost, e.g. when the user |
| - // reloads the current page. When the RenderViewHost itself is deleted, the |
| - // RenderViewDeleted method will be invoked. |
| + // This method is invoked when the process for the current RenderView exits |
|
nasko
2015/07/10 07:48:54
"the process for the current main RenderFrameHost"
Avi (use Gerrit)
2015/07/10 15:29:20
Done.
|
| + // (usually by crashing, though possibly by other means). The WebContents |
| + // continues to use the RenderViewHost, e.g. when the user reloads the current |
| + // page. When the RenderViewHost itself is deleted, the RenderViewDeleted |
| + // method will be invoked. |
| // |
| - // Note that this is equivalent to |
| - // RenderProcessHostObserver::RenderProcessExited(). |
| + // Note that this is triggered upstream through |
| + // RenderProcessHostObserver::RenderProcessExited(); for code that doesn't |
| + // otherwise need to be a WebContentsObserver, consider whether that API might |
|
nasko
2015/07/10 07:48:55
I'd word it a bit more strongly. Unless they have
Avi (use Gerrit)
2015/07/10 15:29:20
Done.
|
| + // be a better choice. |
| virtual void RenderProcessGone(base::TerminationStatus status) {} |
| // This method is invoked when a WebContents swaps its visible RenderViewHost |