Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1228923003: X87: Debugger: record reloc info for debug break slot immediate before the slot. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Debugger: record reloc info for debug break slot immediate before the slot. port 0a19e44925301b9c0a554bbec5e3fb5a6cd09efa (r29568) original commit message: If we do it too early, we might get a constant pool between the reloc info and the actual slot. Committed: https://crrev.com/0b6af2c4150bfb0f50d369c463ed9cb35fd3e940 Cr-Commit-Position: refs/heads/master@{#29642}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/x87/debug-x87.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-14 03:48:42 UTC) #3
Weiliang
lgtm
5 years, 5 months ago (2015-07-14 09:33:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228923003/20001
5 years, 5 months ago (2015-07-14 09:33:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-14 09:59:16 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 09:59:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b6af2c4150bfb0f50d369c463ed9cb35fd3e940
Cr-Commit-Position: refs/heads/master@{#29642}

Powered by Google App Engine
This is Rietveld 408576698