Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Side by Side Diff: src/x87/debug-x87.cc

Issue 1228923003: X87: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 151 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
152 // Register state just before return from JS function (from codegen-x87.cc). 152 // Register state just before return from JS function (from codegen-x87.cc).
153 // ----------- S t a t e ------------- 153 // ----------- S t a t e -------------
154 // -- eax: return value 154 // -- eax: return value
155 // ----------------------------------- 155 // -----------------------------------
156 Generate_DebugBreakCallHelper(masm, eax.bit()); 156 Generate_DebugBreakCallHelper(masm, eax.bit());
157 } 157 }
158 158
159 159
160 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 160 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
161 DebugCodegen::SlotLocation location,
162 int call_argc) {
161 // Generate enough nop's to make space for a call instruction. 163 // Generate enough nop's to make space for a call instruction.
162 Label check_codesize; 164 Label check_codesize;
163 __ bind(&check_codesize); 165 __ bind(&check_codesize);
166 RecordRelocInfo(masm, location, call_argc);
164 __ Nop(Assembler::kDebugBreakSlotLength); 167 __ Nop(Assembler::kDebugBreakSlotLength);
165 DCHECK_EQ(Assembler::kDebugBreakSlotLength, 168 DCHECK_EQ(Assembler::kDebugBreakSlotLength,
166 masm->SizeOfCodeGeneratedSince(&check_codesize)); 169 masm->SizeOfCodeGeneratedSince(&check_codesize));
167 } 170 }
168 171
169 172
170 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 173 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
171 Generate_DebugBreakCallHelper(masm, 0); 174 Generate_DebugBreakCallHelper(masm, 0);
172 } 175 }
173 176
(...skipping 29 matching lines...) Expand all
203 206
204 207
205 const bool LiveEdit::kFrameDropperSupported = true; 208 const bool LiveEdit::kFrameDropperSupported = true;
206 209
207 #undef __ 210 #undef __
208 211
209 } // namespace internal 212 } // namespace internal
210 } // namespace v8 213 } // namespace v8
211 214
212 #endif // V8_TARGET_ARCH_X87 215 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698