Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1228843003: Revert of Change the video color space default. (Closed)

Created:
5 years, 5 months ago by amineer_google
Modified:
5 years, 5 months ago
Reviewers:
bbudge, watk, codebythepound, gunsch, DaleCurtis, lcwu1
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, gunsch+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change the video color space default. (patchset #4 id:60001 of https://codereview.chromium.org/1221903003/) Reason for revert: Causing official continuous builds to fail with the following: ../../media/cast/sender/h264_vt_encoder_unittest.cc:308:22: error: no matching constructor for initialization of 'media::VideoDecoderConfig' VideoDecoderConfig config(kCodecH264, H264PROFILE_MAIN, frame_->format(), ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../media/base/video_decoder_config.h:78:3: note: candidate constructor not viable: requires 10 arguments, but 9 were provided VideoDecoderConfig(VideoCodec codec, ^ ../../media/base/video_decoder_config.h:70:20: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 9 were provided class MEDIA_EXPORT VideoDecoderConfig { ^ ../../media/base/video_decoder_config.h:74:3: note: candidate constructor not viable: requires 0 arguments, but 9 were provided VideoDecoderConfig(); ^ 1 error generated. Original issue's description: > Change the video color space default. > > Previously video without color space metadata was assumed to be in > Rec601. Now the default depends on the kind of playback. Normal src= > defaults to Rec601 for SD sized video (<720 pixels high), and Rec709 for > HD. MSE will always default to Rec709. Using a size based heuristic > doesn't make sense for MSE where it is common for the resolution to > change mid playback. > > This CL doesn't change the meaning of COLOR_SPACE_UNSPECIFIED. Instead, > it adds a color space field to VideoDecoderConfig, and updates the video > decoders to use this as the default if they don't find a more > authoritative value in the bitstream. > > This also fixes a (year old!) bug causing the blackwhite > tests to always succeed, renames the rec709 blackwhite test > file to match the name in blackwhite.html, and re-encodes it > to contain the color space metadata (previously it had none). > > BUG=333619 > > Committed: https://crrev.com/4dc6c2ad0e595a5e0b543e8e1b8961ee0d742a32 > Cr-Commit-Position: refs/heads/master@{#338110} TBR=dalecurtis@chromium.org,bbudge@chromium.org,codebythepound@gmail.com,gunsch@chromium.org,lcwu@chromium.org,watk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=333619 Committed: https://crrev.com/e735fb0c4b13b72561b8f9931a8788e97deced33 Cr-Commit-Position: refs/heads/master@{#338124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -162 lines) Patch
M chromecast/common/media/cma_param_traits.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chromecast/common/media/cma_param_traits_macros.h View 2 chunks +1 line, -4 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/video_decoder_config_marshaller.cc View 5 chunks +1 line, -6 lines 0 comments Download
M chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/test/demuxer_stream_for_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/media/cma/test/mock_frame_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/media_browsertest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 2 chunks +17 lines, -15 lines 0 comments Download
M media/base/test_helpers.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/base/video_decoder_config.h View 2 chunks +8 lines, -15 lines 0 comments Download
M media/base/video_decoder_config.cc View 3 chunks +33 lines, -3 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.h View 1 chunk +2 lines, -5 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 2 chunks +10 lines, -30 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 7 chunks +3 lines, -9 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +1 line, -6 lines 0 comments Download
M media/formats/mp2t/es_adapter_video_unittest.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M media/formats/mp2t/es_parser_h264.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_video_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/media_types.mojom View 2 chunks +0 lines, -10 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 3 chunks +1 line, -19 lines 0 comments Download
D media/test/data/blackwhite_yuv420p_rec709.mp4 View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
amineer_google
Created Revert of Change the video color space default.
5 years, 5 months ago (2015-07-09 20:17:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228843003/1
5 years, 5 months ago (2015-07-09 20:18:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 20:20:47 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 20:21:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e735fb0c4b13b72561b8f9931a8788e97deced33
Cr-Commit-Position: refs/heads/master@{#338124}

Powered by Google App Engine
This is Rietveld 408576698