Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1228833004: Oilpan: Move CachedMetadataHandler to Oilpan heap on Oilpan-enabled world. (Closed)

Created:
5 years, 5 months ago by Yuta Kitamura
Modified:
5 years, 5 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tyoshino+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, gavinp+loader_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Move CachedMetadataHandler to Oilpan heap on Oilpan-enabled world. This patch fixes two raw pointer instances: Resource::CacheHandler::m_resource and ServiceWorkerScriptCachedMetadataHandler::m_workerGlobalScope. BUG=509911 R=haraken@chromium.org, horo@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198945

Patch Set 1 #

Total comments: 5

Patch Set 2 : Move #if directives. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M Source/core/fetch/CachedMetadataHandler.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 4 chunks +15 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Yuta Kitamura
5 years, 5 months ago (2015-07-15 05:43:51 UTC) #1
haraken
LGTM https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp File Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp (right): https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp#newcode26 Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp:26: #if ENABLE(OILPAN) We normally add #if ENABLE(OILPAN) inside ...
5 years, 5 months ago (2015-07-15 07:48:02 UTC) #2
Yuta Kitamura
https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp File Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp (right): https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp#newcode26 Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp:26: #if ENABLE(OILPAN) On 2015/07/15 07:48:02, haraken wrote: > > ...
5 years, 5 months ago (2015-07-15 08:05:34 UTC) #3
haraken
https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp File Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp (right): https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp#newcode26 Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp:26: #if ENABLE(OILPAN) On 2015/07/15 08:05:34, Yuta Kitamura wrote: > ...
5 years, 5 months ago (2015-07-15 08:06:51 UTC) #4
Yuta Kitamura
https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp File Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp (right): https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp#newcode26 Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp:26: #if ENABLE(OILPAN) On 2015/07/15 08:06:50, haraken wrote: > On ...
5 years, 5 months ago (2015-07-15 08:11:03 UTC) #5
Yuta Kitamura
https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp File Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp (right): https://codereview.chromium.org/1228833004/diff/1/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp#newcode26 Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp:26: #if ENABLE(OILPAN) Done, landing.
5 years, 5 months ago (2015-07-15 08:20:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228833004/20001
5 years, 5 months ago (2015-07-15 08:21:14 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 09:35:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198945

Powered by Google App Engine
This is Rietveld 408576698