Source/core/workers/WorkerGlobalScope.cpp - Issue 1228833004: Oilpan: Move CachedMetadataHandler to Oilpan heap on Oilpan-enabled world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerGlobalScope.cpp

Issue 1228833004: Oilpan: Move CachedMetadataHandler to Oilpan heap on Oilpan-enabled world. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move #if directives. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/workers/WorkerGlobalScope.cpp

diff --git a/Source/core/workers/WorkerGlobalScope.cpp b/Source/core/workers/WorkerGlobalScope.cpp

index d93616593bf15e7afaa0e6c145f95a0878ba00c4..0f38b3560345d0f6d25436414be5a4f382066af5 100644

--- a/Source/core/workers/WorkerGlobalScope.cpp

+++ b/Source/core/workers/WorkerGlobalScope.cpp

@@ -256,7 +256,7 @@ void WorkerGlobalScope::importScripts(const Vector<String>& urls, ExceptionState

RefPtrWillBeRawPtr<ErrorEvent> errorEvent = nullptr;

OwnPtr<Vector<char>> cachedMetaData(scriptLoader.releaseCachedMetadata());

- OwnPtr<CachedMetadataHandler> handler(createWorkerScriptCachedMetadataHandler(completeURL, cachedMetaData.get()));

+ OwnPtrWillBeRawPtr<CachedMetadataHandler> handler(createWorkerScriptCachedMetadataHandler(completeURL, cachedMetaData.get()));

m_script->evaluate(ScriptSourceCode(scriptLoader.script(), scriptLoader.responseURL()), &errorEvent, handler.get(), m_v8CacheOptions);

if (errorEvent) {

m_script->rethrowExceptionFromImportedScript(errorEvent.release(), exceptionState);

« no previous file with comments | « Source/core/workers/WorkerGlobalScope.h ('k') | Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »