Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1228803005: Replace Set*Callback with TransitionToAccessorPair (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace Set*Callback with TransitionToAccessorPair BUG=v8:4137 LOG=n Committed: https://crrev.com/103675d68b77c125580f74b2dd12951127f4bc99 Cr-Commit-Position: refs/heads/master@{#29649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -85 lines) Patch
M src/lookup.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lookup.cc View 4 chunks +20 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects.cc View 3 chunks +2 lines, -72 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-14 10:01:16 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-14 10:46:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228803005/1
5 years, 5 months ago (2015-07-14 11:09:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 11:58:37 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 11:58:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/103675d68b77c125580f74b2dd12951127f4bc99
Cr-Commit-Position: refs/heads/master@{#29649}

Powered by Google App Engine
This is Rietveld 408576698