Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1228763003: [arm] Remove unused jump_elimination_allowed parameter to Assembler::branch_offset(). (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
rmcilroy, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Remove unused jump_elimination_allowed parameter to Assembler::branch_offset(). That parameter is just confusing and completely unused. Committed: https://crrev.com/6802c4b921fdc717227fec996e6988ff12a93c1b Cr-Commit-Position: refs/heads/master@{#29547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
Hey Ross, This is an obvious one that I discovered while hunting the constant pool ...
5 years, 5 months ago (2015-07-09 08:19:58 UTC) #2
Yang
On 2015/07/09 08:19:58, Benedikt Meurer wrote: > Hey Ross, > > This is an obvious ...
5 years, 5 months ago (2015-07-09 08:57:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228763003/1
5 years, 5 months ago (2015-07-09 08:58:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 09:00:13 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6802c4b921fdc717227fec996e6988ff12a93c1b Cr-Commit-Position: refs/heads/master@{#29547}
5 years, 5 months ago (2015-07-09 09:00:28 UTC) #7
rmcilroy
5 years, 5 months ago (2015-07-09 09:12:03 UTC) #8
Message was sent while issue was closed.
On 2015/07/09 09:00:28, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/6802c4b921fdc717227fec996e6988ff12a93c1b
> Cr-Commit-Position: refs/heads/master@{#29547}

lgtm too fwiw

Powered by Google App Engine
This is Rietveld 408576698