chrome/browser/app_controller_mac_browsertest.mm - Issue 1228723002: Extract duplicated code in browser_tests for closing a browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac_browsertest.mm

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/app_controller_mac_browsertest.mm

diff --git a/chrome/browser/app_controller_mac_browsertest.mm b/chrome/browser/app_controller_mac_browsertest.mm

index 288b24e4b7c7df1868c8b21eab57013206588a7c..f23b840ddbe0dd986bc05176aa0306b15ce79e0e 100644

--- a/chrome/browser/app_controller_mac_browsertest.mm

+++ b/chrome/browser/app_controller_mac_browsertest.mm

@@ -664,10 +664,9 @@ IN_PROC_BROWSER_TEST_F(AppControllerHandoffBrowserTest, TestHandoffURLs) {

BrowserList::GetInstance(chrome::GetActiveDesktop());

EXPECT_EQ(2u, active_browser_list->size());

- // Close the one and only tab for the second browser window.

+ // Close the second browser window (which only has 1 tab left).

Browser* browser2 = active_browser_list->get(1);

- CloseTab(browser2, 0);

- base::RunLoop().RunUntilIdle();

+ CloseBrowserSynchronously(browser2);

EXPECT_EQ(g_handoff_url, test_url2);

// The URLs of incognito windows should not be passed to Handoff.

« no previous file with comments | « no previous file | chrome/browser/content_settings/content_settings_browsertest.cc » ('j') | chrome/test/base/in_process_browser_test.h » ('J')