Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/test/base/in_process_browser_test.h

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/in_process_browser_test.h
diff --git a/chrome/test/base/in_process_browser_test.h b/chrome/test/base/in_process_browser_test.h
index c6eb60acfef10fc61f1b9ea4133897939ff6171c..9bdb6120531d6eb204f02cd4447fd7dbabadf8b9 100644
--- a/chrome/test/base/in_process_browser_test.h
+++ b/chrome/test/base/in_process_browser_test.h
@@ -108,6 +108,14 @@ class InProcessBrowserTest : public content::BrowserTestBase {
// Returns the browser created by CreateBrowser.
Browser* browser() const { return browser_; }
+ // Closes the given browser and synchronously flushes all of its outstanding
+ // resources.
+ void CloseBrowserSynchronously(Browser* browser);
+
+ // Closes all browsers. No guarantees are made about the destruction of
+ // outstanding resources.
erikchen 2015/07/08 22:05:44 There is only one caller of this method, and I jus
+ void CloseAllBrowsers();
+
// Convenience methods for adding tabs to a Browser.
void AddTabAtIndexToBrowser(Browser* browser,
int index,

Powered by Google App Engine
This is Rietveld 408576698