Issue 12287017: Support set variable value for WebKit protocol

Issue 12287017: Support set variable value for WebKit protocol (Closed)

Created:
7 years, 10 months ago by Peter Rybin

Modified:
7 years, 10 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Support set variable value for WebKit protocol Committed: https://code.google.com/p/chromedevtools/source/detail?r=1137

Patch Set 3 : fcr #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -48 lines)			Patch
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java	View	1 2	7 chunks	+42 lines, -11 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java	View	1 2	8 chunks	+104 lines, -36 lines	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueLoader.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apavlov

LGTM with comments https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java File plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java (right): https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode569 plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:569: ScopeHolderParams holderParams, int number) { "number"? ...

7 years, 10 months ago (2013-02-18 11:34:08 UTC) #2

Peter Rybin

7 years, 10 months ago (2013-02-18 23:32:52 UTC) #3

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
File
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java
(right):

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:569:
ScopeHolderParams holderParams, int number) {
On 2013/02/18 11:34:08, apavlov wrote:
> "number"? Should it be "scopeIndex" instead?

Done.

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:691:
private final int scopeNumber;
On 2013/02/18 11:34:08, apavlov wrote:
> scopeIndex?

Done.

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
File
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java
(right):

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java:665:
VariableImpl(JsValue jsValue, String name, VariableValueChanger valueChanger) {
On 2013/02/18 11:34:08, apavlov wrote:
> While we are here, it is a good idea to swap the JsValue and String arguments,
> since typically the leftmost arguments are passed into the super constructor
to
> improve readability (like, "the first arguments are the most important ones.
> Important enough to go into the superclass").

Done.

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java:674:
@Override public boolean isMutable() {
On 2013/02/18 11:34:08, apavlov wrote:
> Blank line

We usually keep trivial and really simple methods as 3-liners and together with
each other packed without spaces.

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java:677:
@Override public JsValue getValue() {
On 2013/02/18 11:34:08, apavlov wrote:
> Ditto

Same

https://codereview.chromium.org/12287017/diff/2001/plugins/org.chromium.sdk.w...
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipValueBuilder.java:725:
@Override public JsObjectProperty asObjectProperty() {
On 2013/02/18 11:34:08, apavlov wrote:
> Ditto

The same

Expand Messages | Collapse Messages