chromeos/test/data/network/shill_wifi_proxy.json - Issue 1228543002: Translate ONC ProxySettings <-> Shill ProxyConfig

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/test/data/network/shill_wifi_proxy.json

Issue 1228543002: Translate ONC ProxySettings <-> Shill ProxyConfig (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/onc/onc_utils_unittest.cc ('K') | « chromeos/test/data/network/shill_wifi_clientref.json ('k') | chromeos/test/data/network/shill_wifi_psk.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/test/data/network/shill_wifi_proxy.json

diff --git a/chromeos/test/data/network/shill_wifi_proxy.json b/chromeos/test/data/network/shill_wifi_proxy.json

new file mode 100644

index 0000000000000000000000000000000000000000..c7b273f84ee475cb4101d535219e768a5b0d862d

--- /dev/null

+++ b/chromeos/test/data/network/shill_wifi_proxy.json

@@ -0,0 +1,6 @@

+ "Mode": "managed",

+ "ProxyConfig": "{\"bypass_list\":\"google.com;\\u003Clocal>;\",\"mode\":\"fixed_servers\",\"server\":\"ftp=ftp.example.com:5678;http=http.example.com:1234;socks=socks5://socks.example.com:7890;https=https.example.com:3456\"}",

pneubeck (no reviews) 2015/07/07 10:18:48 seems that you got a unicode character \u003C (U+0

stevenjb 2015/07/07 18:30:36 What quotation mark after what? The ONC exclude do

stevenjb 2015/07/07 18:30:36 Unfortunately due to a quirk of our parser if I in

+ "SecurityClass": "none",

+ "Type": "wifi",