chromeos/test/data/network/shill_wifi_proxy.json - Issue 1228543002: Translate ONC ProxySettings <-> Shill ProxyConfig

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/test/data/network/shill_wifi_proxy.json

Issue 1228543002: Translate ONC ProxySettings <-> Shill ProxyConfig (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {

	2 "Mode": "managed",

	3 "ProxyConfig": "{\"bypass_list\":\"google.com;\\u003Clocal>;\",\"mode\":\"fixe d_servers\",\"server\":\"ftp=ftp.example.com:5678;http=http.example.com:1234;soc ks=socks5://socks.example.com:7890;https=https.example.com:3456\"}",
	pneubeck (no reviews) 2015/07/07 10:18:48 seems that you got a unicode character \u003C (U+0 seems that you got a unicode character \u003C (U+003C = '<') into the ONC by mistake. I just wonder where the quotation mark " after google.com went? stevenjb 2015/07/07 18:30:36 What quotation mark after what? The ONC exclude do Show quoted text On 2015/07/07 10:18:48, pneubeck wrote: > seems that you got a unicode character \u003C (U+003C = '<') into the ONC by > mistake. > > I just wonder where the quotation mark " after http://google.com went? What quotation mark after what? The ONC exclude domains are "google.com,<local>". stevenjb 2015/07/07 18:30:36 Unfortunately due to a quirk of our parser if I in Show quoted text On 2015/07/07 10:18:48, pneubeck wrote: > seems that you got a unicode character \u003C (U+003C = '<') into the ONC by > mistake. > > I just wonder where the quotation mark " after http://google.com went? Unfortunately due to a quirk of our parser if I include < in the string, the "expected" value looks like: \\u003Clocal> And the "actual" value looks like: \u003Clocal> After beating my head against this for an hour I decided it was easier just to use the escape code in the .json, rather than figuring out where the extra escaping is coming from.
	4 "SecurityClass": "none",

	5 "Type": "wifi",

	6 }

OLD	NEW