Issue 1228393006: Add a GM that reproduces layout test failures with my new xfermode code.

Issue 1228393006: Add a GM that reproduces layout test failures with my new xfermode code. (Closed)

Created:
5 years, 5 months ago by mtklein_C

Modified:
5 years, 5 months ago

Reviewers:
f(malita), mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Add a GM that reproduces layout test failures with my new xfermode code. Inspired by https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/69169/layout-test-results/results.html I think the root cause is overflow. Also, adds tests for Sk16b::operator<(). It wasn't wrong, but it was suspect (used in all three of these xfermode implementations) and so it's best to have tests. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e20633ed26d211e8d2b4b407c7e968944c7e60bb

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -2 lines)			Patch
	A	gm/buggy_blend_modes.cpp	View		1 chunk	+52 lines, -0 lines	0 comments	Download
	M	tests/SkNxTest.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228393006/1

5 years, 5 months ago (2015-07-13 18:54:04 UTC) #2

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 5 months ago (2015-07-13 19:01:14 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228393006/1

5 years, 5 months ago (2015-07-13 19:05:45 UTC) #9

commit-bot: I haz the power

5 years, 5 months ago (2015-07-13 19:06:37 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e20633ed26d211e8d2b4b407c7e968944c7e60bb