Issue 1228263002: Fix downloads-related web_dev_style presubmit issues.

Issue 1228263002: Fix downloads-related web_dev_style presubmit issues. (Closed)

Created:
5 years, 5 months ago by Dan Beam

Modified:
5 years, 5 months ago

Reviewers:
tommycli

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-rough-draft2

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix downloads-related web_dev_style presubmit issues. R=tommycli@chromium.org BUG=425626 TEST=presubmit shuts up Committed: https://crrev.com/bed09bab3f90b337c6b3f59fe038b71e73b3741e Cr-Commit-Position: refs/heads/master@{#338321}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -86 lines)			Patch
M	chrome/browser/resources/downloads/downloads.html	View	3 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/downloads/item_view.js	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/downloads/manager.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/downloads.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/item_view.html	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/item_view.js	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/md_downloads/manager.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/downloads_ui.cc	View	1 chunk	+25 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/webui/downloads_ui_browsertest.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Depends on Patchset:

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228263002/1

5 years, 5 months ago (2015-07-10 17:42:26 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-10 17:51:03 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bed09bab3f90b337c6b3f59fe038b71e73b3741e
Cr-Commit-Position: refs/heads/master@{#338321}