Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/resources/md_downloads/item_view.js

Issue 1228263002: Fix downloads-related web_dev_style presubmit issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dl-rough-draft2
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_downloads/item_view.js
diff --git a/chrome/browser/resources/md_downloads/item_view.js b/chrome/browser/resources/md_downloads/item_view.js
index d0b74903724d0ddd9808fec8c8941d2713b29832..75bf86fb9d79342a7e26c082984b7534d49a8934 100644
--- a/chrome/browser/resources/md_downloads/item_view.js
+++ b/chrome/browser/resources/md_downloads/item_view.js
@@ -98,7 +98,7 @@ cr.define('downloads', function() {
this.$.cancel.hidden = !showCancel;
this.$['safe-remove'].hidden = showCancel ||
- !loadTimeData.getBoolean('allow_deleting_history');
+ !loadTimeData.getBoolean('allowDeletingHistory');
/** @const */ var controlledByExtension = data.by_ext_id &&
data.by_ext_name;
@@ -139,18 +139,16 @@ cr.define('downloads', function() {
getDangerText_: function(data) {
switch (data.danger_type) {
case downloads.DangerType.DANGEROUS_FILE:
- return loadTimeData.getStringF('danger_file_desc', data.file_name);
+ return loadTimeData.getStringF('dangerFileDesc', data.file_name);
case downloads.DangerType.DANGEROUS_URL:
- return loadTimeData.getString('danger_url_desc');
+ return loadTimeData.getString('dangerUrlDesc');
case downloads.DangerType.DANGEROUS_CONTENT: // Fall through.
case downloads.DangerType.DANGEROUS_HOST:
- return loadTimeData.getStringF('danger_content_desc', data.file_name);
+ return loadTimeData.getStringF('dangerContentDesc', data.file_name);
case downloads.DangerType.UNCOMMON_CONTENT:
- return loadTimeData.getStringF('danger_uncommon_desc',
- data.file_name);
+ return loadTimeData.getStringF('dangerUncommonDesc', data.file_name);
case downloads.DangerType.POTENTIALLY_UNWANTED:
- return loadTimeData.getStringF('danger_settings_desc',
- data.file_name);
+ return loadTimeData.getStringF('dangerSettingsDesc', data.file_name);
default:
return '';
}
@@ -168,7 +166,7 @@ cr.define('downloads', function() {
assert(typeof data.progress_status_text == 'string');
return data.progress_status_text;
case downloads.States.CANCELLED:
- return loadTimeData.getString('status_cancelled');
+ return loadTimeData.getString('statusCancelled');
case downloads.States.DANGEROUS:
break; // Intentionally hit assertNotReached(); at bottom.
case downloads.States.INTERRUPTED:
@@ -176,7 +174,7 @@ cr.define('downloads', function() {
return data.last_reason_text;
case downloads.States.COMPLETE:
return data.file_externally_removed ?
- loadTimeData.getString('status_removed') : '';
+ loadTimeData.getString('statusRemoved') : '';
}
assertNotReached();
return '';
« no previous file with comments | « chrome/browser/resources/md_downloads/item_view.html ('k') | chrome/browser/resources/md_downloads/manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698