Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 1228223002: Close wrench menu when Media Router Action clicked in Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per rdevlin.cronin@'s comments and rebase. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
index 249042b03c39315d87a1cb9901c8b54b95f20bf8..0c497de4ed393f9c9129b49c1f645fd0db31ae76 100644
--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
@@ -33,7 +33,7 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
->browser_actions();
ASSERT_TRUE(browser_actions_container);
- media_router_action_.reset(new MediaRouterAction);
+ media_router_action_.reset(new MediaRouterAction(browser()));
// Sets delegate on |media_router_action_|.
toolbar_action_view_.reset(
@@ -45,6 +45,11 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
content::TestNavigationObserver nav_observer(NULL);
nav_observer.StartWatchingNewWebContents();
media_router_action_->ExecuteAction(true);
+
+ ToolbarView* toolbar =
+ BrowserView::GetBrowserViewForBrowser(browser())->toolbar();
+ ASSERT_FALSE(toolbar->IsWrenchMenuShowing());
Devlin 2015/07/14 21:31:07 ... But the wrench menu is never opened, right? W
apacible 2015/07/16 16:52:11 ... good point. Opening the wrench menu prior to t
+
nav_observer.Wait();
nav_observer.StopWatchingNewWebContents();
}

Powered by Google App Engine
This is Rietveld 408576698